Meenashi - Takeover: Sanjeev30 sanjeev phase 2 financial summary data apis#1595
Merged
one-community merged 4 commits intoAug 5, 2025
Merged
Conversation
…/github.com/sanjeev30/HGNRest into sanjeev30-sanjeev_phase_2_financial_summary_data_apis
jeyanthi-sm
changed the title
jeyanthi-sm
changed the title
one-community
added
the
High Priority - Please Review First
ShravyaKudlu
approved these changes
Jul 30, 2025
Contributor
ShravyaKudlu
left a comment
ShravyaKudlu
left a comment
There was a problem hiding this comment.
Was able to review these changes successfully
ManviKishore
approved these changes
Jul 31, 2025
Contributor
ManviKishore
left a comment
ManviKishore
left a comment
There was a problem hiding this comment.
All the APIs working as expected.
Contributor
|
I tested all the changes and everything is working as expected. |
suparshwa31
approved these changes
Jul 31, 2025
Contributor
suparshwa31
left a comment
suparshwa31
left a comment
There was a problem hiding this comment.
All endpoints working.
csk731
approved these changes
Aug 1, 2025
Contributor
csk731
left a comment
csk731
left a comment
There was a problem hiding this comment.
Reviewed this PR by running this branch locally. All changes look fine and APIs are giving expected responses.
…GNRest into sanjeev30-sanjeev_phase_2_financial_summary_data_apis
sohailuddinsyed
approved these changes
Aug 2, 2025
Contributor
sohailuddinsyed
left a comment
sohailuddinsyed
left a comment
There was a problem hiding this comment.
All of the given API endpoints are working as expected
- Total Project Cost
GET /api/financials/project/{projectId}/total-cost
- Project Cost Breakdown
GET /api/financials/project/{projectId}/costs
- Month-over-Month Change (Current vs. Previous)
GET /api/financials/project/{projectId}/mom-changes
- Projects by Date Range
GET /api/financials/projects?startDate=2025-04-01&endDate=2025-08-01
- Projects by Type
GET /api/financials/projects?projectType=commercial
All endpoints tested using API Key in Authorization header.
Token included in all requests and verified successfully.
|
one-community
changed the title
all endpoints working |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR continues the work originally started by @sanjeev30 in the sanjeev_phase_2_financial_summary_data_apis branch.
Summary of Changes:
Integrated Sanjeev’s original API work for the Phase 2 Financial Summary module.
Pulled and merged with the latest development branch.
Resolved merge conflicts in the following file:
src/startup/routes.js
Verified that protected functions remain unchanged.
Reason for Takeover:
Sanjeev was unavailable to complete the PR, so I have taken over to finalize, clean up, and prepare it for merge.
Related PRs
Main Changes Explained
developmentroutes.jsHow to Test
Pull this backend branch
Run npm install
Run npm run dev to start the server locally
Execute the api/login endpoint using the POST method to retrieve an authentication token.
Use this token as the API key for all subsequent API requests.
Verified the responses of the listed APIs
Total Project Cost
GET /api/financials/project/{projectId}/total-cost
Project Cost Breakdown
GET /api/financials/project/{projectId}/costs
Month-over-Month Change (Current vs. Previous)
GET /api/financials/project/{projectId}/mom-changes
Projects by Date Range
GET /api/financials/projects?startDate=2025-04-01&endDate=2025-06-01
Projects by Type
GET /api/financials/projects?projectType=commercial
Screenshots or Videos
Notes
src/startup/routes.js, where the conflict occurred.Related PRS (if any):